Blog entries - Codeforces

#	User	Rating
1	tourist	4009
2	jiangly	3823
3	Benq	3738
4	Radewoosh	3633
5	jqdai0815	3620
6	orzdevinwang	3529
7	ecnerwala	3446
8	Um_nik	3396
9	ksun48	3390
10	gamegame	3386

#	User	Contrib.
1	cry	167
2	Um_nik	163
3	maomao90	162
3	atcoder_official	162
5	adamant	159
6	-is-this-fft-	158
7	awoo	157
8	TheScrasse	154
9	Dominater069	153
9	nor	153

I have been practicing bitsets and I have read that using a bitset is better than using a vector of bools. I attempted to solve the following problem:

https://www.codechef.com/problems/CHEFQUE

The vector of bools gave me AC but the bitset gave me a compilation error.

The code that passes:

Code that passes

#include<bits/stdc++.h>
using namespace std;
#define ll long long
#define pb push_back
#define mp make_pair
#define F first
#define S second
#define mod 1000000007

const ll N = (1LL << 31) + 25;
const ll m = (1LL << 32);
vector<bool> bit(N);

void solve()
{
    ll n,i,j,k,x,y,z,target,tot;
    ll q,s1,a,b;
    cin >> q >> s1 >> a >> b;
    ll s = s1;
    ll ans=0;

    while(q-- > 0)
    {

        x = s/2;

        if(s%2 == 1)
        {

            if(!bit[x])
            {
                bit[x] = true;
                ans += x;
            }
        }
        else
        {

            if(bit[x])
            {
                bit[x] = false;
                ans -= x;
            }

        }

        s = (s*a + b)%m;
    }

    cout << ans;

}
int main()
{

    //freopen("input.txt", "r", stdin);
    //freopen("output.txt", "w", stdout);
	ios_base::sync_with_stdio(0);
	cin.tie(0);
	cout.tie(0);
        ll t=1;
	//cin >> t;

	while(t-- > 0)
	{
	    solve();

	}
}

The code that gives an error:

Code that gives error

#include<bits/stdc++.h>
using namespace std;
#define ll long long
#define pb push_back
#define mp make_pair
#define F first
#define S second
#define mod 1000000007

const ll N = (1LL << 31) + 25;
const ll m = (1LL << 32);

bitset<N> bit;

void solve()
{

    ll n,i,j,k,x,y,z,target,tot;
    ll q,s1,a,b;
    cin >> q >> s1 >> a >> b;
    ll s = s1;
    ll ans=0;

    while(q-- > 0)
    {

        x = s/2;

        if(s%2 == 1)
        {

            if(bit[x] == 0)
            {
                bit[x] = 1;
                ans += x;
            }
        }
        else
        {

            if(bit[x] == 1)
            {
                bit[x] = 0;
                ans -= x;
            }

        }

        s = (s*a + b)%m;
    }

    cout << ans;
}
int main()
{

    //freopen("input.txt", "r", stdin);
    //freopen("output.txt", "w", stdout);
	ios_base::sync_with_stdio(0);
	cin.tie(0);
	cout.tie(0);
        ll t=1;
	//cin >> t;

	while(t-- > 0)
	{
	    solve();

	}
}

Any help would be appreciated.

Full text and comments »

anotherTry's blog