My Program Stops Running Unexpectedly

Блог пользователя Qualified

Автор Qualified, история, 6 лет назад, По-английски

Hi, I am trying to do 723B - Text Document Analysis and here is my code.

Code

int main() { ios::sync_with_stdio(0); cin.tie(0);

int n;
cin >> n;
string s;
getline(cin, s);
for(int i = 0; i < n; i++) {
    if(s[i] == '_') {
       s[i] = ' ';
    }
}
stringstream ss(s);
bool ans = false;
string s1;
int maxx = -1;
int cnt = 0;
while(ss >> s1) {
    if(s1[0] == '(') {
       ans = true;
       cnt++;
    } else if(s1[0] == ')') {
       ans = false;
       cnt++;
    } else {
       if(ans) {
         cnt++;
       } else {
         int i = s1.size();
         maxx = max(maxx, i);
       }
    }
}
cout << maxx << " " << cnt;

}

When I input 37, which is the example input, the program just returns maxx and cnt. I don't understand this. Am I doing something wrong. BTW I am using GVim.

Qualified
6 лет назад
5

Комментарии (5)

Написать комментарий?

qpwoeirut

6 лет назад, скрыть # |

+14

After you do cin >> n, the pointer for your input is still on the same line as n. So then getline returns the remainder of that line, which is just a newline character. Changing getline to cin >> s should fix the error, since s is guaranteed to not have spaces.

Also, your code doesn't separate words if the separator is ( or ). Printing s1 inside the while loop will demonstrate this.

→ Ответить

Qualified

6 лет назад, скрыть # ^ |

What if the problem had spaces, how would I input that? But thanks for the reply!

→ Ответить

qpwoeirut

6 лет назад, скрыть # ^ |

If the problem has spaces, your getline should work as long as you add cin >> ws after cin >> n. This will take all the whitespace and discard it, which should put you at the start of the next line.

But I think (or at least I hope) that the writers will make efforts to ensure you never need to do this. So far I haven't seen a CF problem requiring cin >> ws for input.

→ Ответить