ABhinav2003's blog

Problem 702A — Maximum Increase | What is wrong in this Plz HELP I SPENT 2 Days finding bug PLZZZZ HELP.
By ABhinav2003, history, 4 years ago, In English 
#include<bits/stdc++.h>
using namespace std;
int in=0 , ex;
int sub(int a[] , int len)
{
//	if(len<1)
//		return 0;
	 if(len <= 0  )
		return 0;

	  ex = sub(a,len-1);
	  cout<<"EX "<<ex<<"\n";

	 if(a[len-1] >a[len-2])
	 {
		int t = a[len-1]>a[len-2];cout<<"T "<<t<<"\n";
	 	 in = 1+sub(a,len-1);
	 }
	 cout<<"IN "<<in<<"\n";

	int max1 = max(in,ex);
	cout<<"MAX "<<max1<<"\n";

	return max1;
}

int main()
{
	int len;
	cin>>len;
	 int a[len];
	for(int i = 0;i<=len-1;i++)
	{
		cin>>a[i];
	}
	int m = sub(a , len);
	cout<<m;
}
[**HERE IS THE PROBLEM**](https://mirror.codeforces.com/problemset/problem/702/A)
  • Vote: I like it
  • 0
  • Vote: I do not like it

Comments Comments (7)
| Write comment?
»
4 years ago, # |
  Vote: I like it +3 Vote: I do not like it

There are many flaws in this code.

  1. Base case is len <= 0 so, when len = 1, the index of a[len-2] will become negative.
  2. in is a global variable, you'll have to add in = 0 before the if statement.

Even if you correct these flaws, the basic flaw is that this method will give you a subsequence instead of a subarray.

For example, for the input 1 2 3 10 4 5 6, your output will be 6 (after correcting the mentioned 2 points).

→ Reply
  • »
    »
    4 years ago, # ^ |
      Vote: I like it 0 Vote: I do not like it

    PLZ CAN U CORRECT MY FLAW AND GIVE IT TO ME I CAN"T UNDERSTAND IT PROPERLY BRO PLZ HELP I AM struggling for about 2-3 days now and not able to do this

    actually i have just started DP PLZ UNDERSTAND AND HELP ME JUST REWRITE THE FUNCTION WITH REMOVING ALL FLAWS

    → Reply
    • »
      »
      »
      4 years ago, # ^ |
        Vote: I like it +12 Vote: I do not like it

      https://www.wikihow.com/Turn-Off-Caps-Lock

      → Reply
    • »
      »
      »
      4 years ago, # ^ |
        Vote: I like it +6 Vote: I do not like it
      Recursive code which will give TLE
      Memoized version of the same code
      No dp required

      I'd strictly recommend you to learn dp first or you might not understand my solution.

      → Reply
  • »
    »
    9 months ago, # ^ |
      Vote: I like it 0 Vote: I do not like it

    I am having some problem with same question i have applied non dp version same as yours but i am still getting wrong ans in test 5

    heres the code import java.util.Scanner;

    /** * A702 */ public class A702 {

    public static void main(String[] args) {
    Scanner sc = new Scanner(System.in);
    int n = sc.nextInt();
    int a[] = new int[n];
    int highest = 1;

    for (int i = 0; i < a.length; i++) {
        a[i] = sc.nextInt();
    }
    int current = 1;
    for (int i = 1; i < a.length; i++) {
        if (a[i] > a[i - 1]) {
            current++;
        } else if ( current > highest) {
            highest = current;
            current = 1;
        }
    }

    if (current > highest) {
        highest = current;
    }

    System.out.println(highest);

}

    }

    → Reply
    • »
      »
      »
      9 months ago, # ^ |
      ← Rev. 2   Vote: I like it 0 Vote: I do not like it

      My first ever Java Submission on any website, for you.
      (Well actually 2nd, because 1st was compilation error.)

      Change:

      if (a[i] > a[i - 1]) {
    current++;
} else {
   if ( current > highest) {
        highest = current;
   }
   current = 1; // This has to be done evertime you see non-increasing element.
}
      → Reply
      • »
        »
        »
        »
        9 months ago, # ^ |
          Vote: I like it 0 Vote: I do not like it

        thanks man, yes i noticed that logical error after this post ,but thank you for your response i really appreciate it

        → Reply