Can you give me the easy and understandable implementation of Miller Rabin in C++?
# | User | Rating |
---|---|---|
1 | tourist | 4009 |
2 | jiangly | 3773 |
3 | Radewoosh | 3646 |
4 | ecnerwala | 3624 |
5 | jqdai0815 | 3620 |
5 | Benq | 3620 |
7 | orzdevinwang | 3612 |
8 | Geothermal | 3569 |
8 | cnnfls_csy | 3569 |
10 | gyh20 | 3447 |
# | User | Contrib. |
---|---|---|
1 | awoo | 161 |
2 | maomao90 | 160 |
3 | nor | 157 |
4 | atcoder_official | 156 |
4 | cry | 156 |
6 | -is-this-fft- | 155 |
7 | maroonrk | 154 |
8 | adamant | 153 |
9 | Um_nik | 151 |
10 | djm03178 | 146 |
Name |
---|
https://cp-algorithms.com/algebra/primality_tests.html#toc-tgt-2
but it gives wrong output in some cases. Example: 999999999999999989 its a prime number but the output is its a composite number.
Are you sure? I just tried it, and
MillerRabin(999999999999999989LL)
returnstrue
, indicating that it is probably prime.You must made an error calling the function (maybe you forgot to mark it as a long long number?).
Also, if you want to go safe, just use the deterministic Miller-Rabin code, from the next section.